Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/nexus v1.2.0 ep v0.7 #242

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Feb 20, 2025


PR-Codex overview

This PR primarily focuses on enhancing the Nexus smart contract architecture by adding new features, improving existing functionalities, and refining the deployment process. It introduces new error handling, updates contract versions, and modifies test cases to ensure compatibility.

Detailed summary

  • Removed old deployment scripts and test files.
  • Added defaultValidator to the deployer class.
  • Updated .solhint.json to modify linting rules.
  • Introduced MockTarget contract with setValue function.
  • Added new error types in EventsAndErrors.sol and INexusEventsAndErrors.sol.
  • Updated BaseAccount implementation version.
  • Enhanced the EmergencyUninstall struct for better hook management.
  • Refined TestFuzz_ExecuteSingleFromExecutor assumptions.
  • Updated Nexus contract constructor to include defaultValidator.
  • Improved MockValidator to use getOwner method.
  • Modified factory and bootstrapper contracts for better initialization.
  • Updated tests to reflect contract changes and ensure accurate assertions.

The following files were skipped due to too many changes: test/foundry/unit/concrete/factory/TestNexusAccountFactory_Deployments.t.sol, contracts/modules/validators/K1Validator.sol, test/hardhat/smart-account/Nexus.Basics.specs.ts, contracts/factory/K1ValidatorFactory.sol, contracts/mocks/MockPreValidationHookMultiplexer.sol, contracts/utils/NexusBootstrap.sol, test/hardhat/utils/deployment.ts, test/foundry/unit/concrete/erc1271/TestERC1271Account_MockProtocol.t.sol, contracts/mocks/Mock7739PreValidationHook.sol, test/foundry/integration/TestNexusPreValidation_Integration_ResourceLockHooks.t.sol, test/foundry/unit/concrete/modulemanager/TestModuleManager_EnableMode.t.sol, test/foundry/unit/concrete/eip7702/TestEIP7702.t.sol, test/foundry/utils/TestHelper.t.sol, test/foundry/integration/TestNexusPreValidation_Integration_Multiplexer.t.sol, contracts/Nexus.sol, contracts/base/ModuleManager.sol, test/foundry/unit/concrete/hook/TestNexus_Hook_Emergency_Uninstall.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

highskore and others added 29 commits December 10, 2024 11:34
Remove dependency of tests on scripts
Fix test case for delegate call test_ExecuteDelegateCallFromExecutor_Success
Make Module Enable Mode compatible with 7702
Copy link

openzeppelin-code bot commented Feb 20, 2025

Release/nexus v1.2.0 ep v0.7

Generated at commit: ac751b450c6695aa73c2ee4fa8a7f17ca4d5ee3b

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
29
37

For more details view the full report in OpenZeppelin Code Inspector

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (2 results) (Medium)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ModuleManager.sol#L242-L246

base/ModuleManager.sol#L219-L228

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants