-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/nexus v1.2.0 ep v0.7 #242
Open
filmakarov
wants to merge
37
commits into
main
Choose a base branch
from
release/nexus-v1.2.0-ep-v0.7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dependency of tests on scripts
feat: add eip7702 support
Signed-off-by: Manank Patni <[email protected]>
Fix test case for delegate call test_ExecuteDelegateCallFromExecutor_Success
feat: add prevalidation hook support
Make Module Enable Mode compatible with 7702
Secure batch decode implementation
Release/nexus v1.2.0 ep v0.7
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Default validator for ep v7 Nexus version
🤖 Slither Analysis Report 🔎Slither report
# Slither report
_This comment was automatically generated by the GitHub Actions workflow._
THIS CHECKLIST IS NOT COMPLETE. Use
unused-return🟡 Impact: Medium
base/ModuleManager.sol#L242-L246
base/ModuleManager.sol#L219-L228 constable-statesImpact: Optimization
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR primarily focuses on enhancing the
Nexus
smart contract architecture by adding new features, improving existing functionalities, and refining the deployment process. It introduces new error handling, updates contract versions, and modifies test cases to ensure compatibility.Detailed summary
defaultValidator
to thedeployer
class..solhint.json
to modify linting rules.MockTarget
contract withsetValue
function.EventsAndErrors.sol
andINexusEventsAndErrors.sol
.BaseAccount
implementation version.EmergencyUninstall
struct for better hook management.TestFuzz_ExecuteSingleFromExecutor
assumptions.Nexus
contract constructor to includedefaultValidator
.MockValidator
to usegetOwner
method.