Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 7702 via proper code etching with Prague hardfork #244

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Feb 21, 2025

PR-Codex overview

This PR focuses on updating the configurations and tests related to the evm_version and ERC7702 functionality in the smart contract testing framework. It enhances the assumptions in tests and modifies the implementation details for better compatibility with the ERC7702 standard.

Detailed summary

  • Updated evm_version in foundry.toml from cancun to prague.
  • Changed assumption in testFuzz_ExecuteSingleFromExecutor to ensure target address is greater than 255.
  • Revised the comment in the _amIERC7702 function for clarity.
  • Updated the vm.etch call in _doEIP7702 to properly encode the ACCOUNT_IMPLEMENTATION address.
  • Restored the test for amIERC7702 functionality in test_amIERC7702_success to work correctly with the new vm.etch implementation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@filmakarov filmakarov merged commit 2985f98 into release/eip-7702-sepolia-pre-release Feb 21, 2025
5 of 6 checks passed
@filmakarov filmakarov deleted the feat/test-7702-via-foundry-cheatcodes branch February 21, 2025 09:05
@filmakarov filmakarov mentioned this pull request Feb 21, 2025
2 tasks
Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)
🟡 - unused-return (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L189

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

lib/ExecLib.sol#L125-L139

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

Copy link

Test 7702 via proper code etching with Prague hardfork

Generated at commit: 77622cb227b4790c95e84c6642de726665270eeb

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
7
30
39

For more details view the full report in OpenZeppelin Code Inspector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant