Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to advice user to insert the correct ip when starting the example #31

Open
AleksandarFilipov opened this issue Apr 23, 2021 · 2 comments
Open

Make sure to advice user to insert the correct ip when starting the example #31

AleksandarFilipov opened this issue Apr 23, 2021 · 2 comments
Assignees
@elliotjon

Comments

@AleksandarFilipov
Copy link
Contributor

https://github.com/beamylabs/beamylabs-start/blob/master/examples/grpc/python/README.md#setup

currently uses 127.0.0.1 which probably isn't correct in many cases.
@AleksandarFilipov
Copy link
Contributor Author

or actually provide it as a parameter when starting.

@elliotjon
Copy link
Contributor

elliotjon commented Jun 4, 2021 •
edited
Loading

Places where this should be updated;

  • playback.py > merged to master
  • simple_example.1.py > removed in branch issue-31-add-ip-on-start
  • simple_example.2.py > removed in branch issue-31-add-ip-on-start
  • simple_example.py > removed in branch issue-31-add-ip-on-start
  • resp_to_diag_req.py + add README
  • ecu.py > merged to master
  • ecu_advanced.py > merged to master
  • simple_example_garage.py + add README
  • virtual_example_pub.py + updated README
  • virtual_example_sub.py + updated README

@elliotjon elliotjon mentioned this issue Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elliotjon elliotjon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 31 add ip on start beamylabs/beamylabs-start
2 participants
@AleksandarFilipov @elliotjon