Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extracted bundle handling #372

Open
ir4y opened this issue Nov 18, 2024 · 0 comments
Open

Refactor extracted bundle handling #372

ir4y opened this issue Nov 18, 2024 · 0 comments

Comments

@ir4y
Copy link
Member

ir4y commented Nov 18, 2024

Now return extracted boolean flag and two optional objects: extractedBundle and extractedError.

questionnaireResponse: saveQRRemoteData.data,
extracted: isSuccess(extractRemoteData),
extractedError: isFailure(extractRemoteData) ? extractRemoteData.error : undefined,
extractedBundle: isSuccess(extractRemoteData) ? extractRemoteData.data : undefined,

It should be a RemoteData object, all underling code should be refactored, this TODOs

// TODO: save extract result info QuestionnaireResponse.extractedResources and store
// TODO: extracted flag
should be fixed.

@ir4y ir4y added the good first issue Good for newcomers label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant