Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOT_SIZE error #6

Open
FreshLondon opened this issue May 20, 2018 · 5 comments
Open

LOT_SIZE error #6

FreshLondon opened this issue May 20, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@FreshLondon
Copy link

Hey @bencagri,

I'm testing your project (before we start, thanks in advance).

Installed, ran, seemed to go ok for a few seconds then I quit to adjust parameters.
I changed the default % and see a LOT_SIZE error.

screen shot 2018-05-21 at 03 43 02

I'm assuming this is looking for 2 decimal places, I edited to two and it now works.
I'm only reporting this as others may come across the issue, save time!

@FreshLondon
Copy link
Author

screen shot 2018-05-21 at 03 48 19

weird.. ill experiment for now

@bencagri
Copy link
Owner

Hi @CreativeBacon

First thanks for your contribution.
The status of the repo is still in progress.

And the LOT_SIZE is a problem that binance gives us. Seems that a lot of user getting this error.
https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md#lot_size

This repo uses, larislackers/php-binance and I think I can change it. I need to investigate the exact problem.

If you can do that, I appreciate.

@FreshLondon
Copy link
Author

aha, understood. Yes, i saw several similar issues on the web when searching earlier (before my first post).

Have you looked at https://github.com/TinyUlt/node_binance_friedcoin ?

Seems interesting, almost inspiring.. :)

@FreshLondon
Copy link
Author

ahhhh, i get what you mean - there is no filter currently in place for LOT_SIZE in the Mokka project?

@FreshLondon
Copy link
Author

see here example of a filter in place for each currency pair:
https://github.com/askmike/gekko/blob/develop/exchanges/binance-markets.json

Annoying part is that every currency would require a different lot size, maybe extract ones already created from this LONG list? 👍

@bencagri bencagri added the bug Something isn't working label May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants