Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit script inclusion only to pages with <firebase> tags #1

Open
bennlich opened this issue Aug 23, 2012 · 1 comment
Open

Limit script inclusion only to pages with <firebase> tags #1

bennlich opened this issue Aug 23, 2012 · 1 comment
Assignees

Comments

@bennlich
Copy link
Owner

Currently, once the Firebase extension is installed, the ext.Firebase.js script is added to all pages of the wiki, which is wasteful, as it only needs to be added to pages that actually have scripts. I'm still trying to figure out how to fix this though.

One pseudo-fix is to include a check in ext.Firebase.js for elements, so that the bulk of the script is not run unnecessarily. But there must be a better way.

@ghost ghost assigned bennlich Aug 23, 2012
@bennlich
Copy link
Owner Author

bennlich commented Sep 7, 2012

I added the check for elements to the script. The check doesn't seem to provide much of a performance hit, but I'm leaving the issue open as there's gotta be a better way to deal with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant