Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCloud driver #266

Closed
kynx opened this issue Nov 19, 2016 · 5 comments
Closed

OpenCloud driver #266

kynx opened this issue Nov 19, 2016 · 5 comments
Assignees

Comments

@kynx
Copy link
Contributor

kynx commented Nov 19, 2016

I've written a driver for php-opencloud which I'd like to send a PR for. But I've got a couple of questions...

  1. Looking at the Doctrine driver, if you pushMessage() to a non-existent queue it'll get created for you. But it doesn't look like SQS or IronMQ work that way (though I'm not at all familiar with the underlying API). What's right?
  2. By default the php-opencloud API doesn't return the client's own messages when listing them, but looking at the Doctrine driver's peekQueue() I think it probably should. Is that right?
  3. The tests I've got require a Rackspace account. I don't like mocking what I don't know, but I guess I could skip them if an account isn't available and add some mocks. What's the best approach here?

Thanks!

@henrikbjorn henrikbjorn self-assigned this Nov 19, 2016
@kynx
Copy link
Contributor Author

kynx commented Nov 22, 2016

OK, I'm converting the tests to use Guzzle's MockPlugin to simulate the responses from the API. That way at least the php-opencloud touch points get tested.

@kynx
Copy link
Contributor Author

kynx commented Nov 23, 2016

My code is available over here. I'd do a PR right away, but I'm beginning to think this would be better in a separate repository (as maybe would the other drivers?). There are a couple of reasons:

  • The current stable version php-opencloud has a dependency on Guzzle 3, which creates an ugly warning in composer
  • Version 2 of php-opencloud is in the works, but not progressing quickly. It looks to be PHP7+, as opposed to Bernard's 5.4+
  • I'd like to have a go at creating a v2 version, but that would be much easier in a separate repo

@henrikbjorn - what are your thoughts? I'll do a PR against this repo if you want. Or if you think a separate repo is a good idea, create one and I'll do a PR against that. Cheers!

@henrikbjorn
Copy link
Contributor

Hey @kynx

I created https://github.com/bernardphp/OpenCloud for you.

@kynx
Copy link
Contributor Author

kynx commented Nov 24, 2016

Awesome! PR is at bernardphp/OpenCloud#1

@sagikazarmark
Copy link
Contributor

Moving to bernardphp/drivers#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants