The disable_network marker does not disable network in fixtures

[jond01]

Env.

• Python 3.11
• Pytest 7.4.3
• pytest-network@4e98d81 (current master)

Case

The following test passes:

import urllib.request

import pytest


@pytest.fixture
def some_network_resource() -> str:
    with urllib.request.urlopen(
        "https://github.com/best-doctor/pytest_network"
    ) as response:
        return response.read().decode()


@pytest.mark.disable_network
def test_network_disabled(some_network_resource: str) -> None:
    assert some_network_resource

The expected behavior is a failure.

Explanation

The fixture runs before the pytest_runtest_call hook:

pytest_network/pytest_network.py

Line 52 in 4e98d81

def pytest_runtest_call(item):

Proposed solution

Change L52 above to pytest_runtest_setup:

def pytest_runtest_setup(item):

See also:

• https://docs.pytest.org/en/7.4.x/reference/reference.html#pytest.hookspec.pytest_runtest_protocol
• https://github.com/jond01/xil/blob/4f21d8230c6b2b58e919b36fcbea689cc730fa8e/tests/conftest.py#L71