Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] Confirmation codes should expire #25

Open
andrewmclagan opened this issue May 10, 2018 · 5 comments
Open

[security] Confirmation codes should expire #25

andrewmclagan opened this issue May 10, 2018 · 5 comments

Comments

@andrewmclagan
Copy link

There is a security risk that confirmation codes to not expire.

  1. MaliciousUser requests confirmation be sent.
  2. MaliciousUser intercepts email
    • (yes this is really really easy)
    • (emails are plain text)
  3. Email contains email address, userId and confirmation code.
  4. MaliciousUser can now confirm.
@bestmomo
Copy link
Owner

Hi,
It's the same way for password reset.

@LucasLeandro1204
Copy link

I think it's not, because you have to login after confirmation. I don't care if someone confirm my email faster than me xd.

@andrewmclagan
Copy link
Author

andrewmclagan commented May 14, 2018

Wrong its really easy to write a bot to subscribe 10000 people. Then confirm them. Never assume that a security hole wont be exploited in the worst kinda way....

Your users will be spammed and you'll loose all their trust.

@andrewmclagan
Copy link
Author

Laravel password resets expire.

@jeehag
Copy link

jeehag commented Jan 16, 2019

It's a real problem and can be security hole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants