Proposal: Beautify code and project struct #1139
liuhao2050
started this conversation in
General
Replies: 2 comments
-
Good advice. |
Beta Was this translation helpful? Give feedback.
0 replies
-
@liuhao2050 感谢您的反馈! BFE项目已有近10年历史,项目早期代码规范与目前Go社区规范有少量差异(出于可读性考虑)。例如:
其中1/2/3属于偏好性差异,对提高可读性无影响;第4有待优化,欢迎提交PR |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Is your feature request related to a problem? Please describe.
This project is write in go, but many code isn't following go styles. To be a great CNCF project, may be we should make our code more idiomatic. Following are some controversial codes:
package bfe_server
In blog Package names of golang official
NewHttpsListener
should be named toNewHTTPSListener
4. Package docs not standard
Describe the solution you'd like
Additional context
Just some advice.
Beta Was this translation helpful? Give feedback.
All reactions