Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Remove unnecessary permissions in Helm Charts #88

Open
Yseona opened this issue May 25, 2024 · 0 comments
Open

Bug: Remove unnecessary permissions in Helm Charts #88

Yseona opened this issue May 25, 2024 · 0 comments

Comments

@Yseona
Copy link

Yseona commented May 25, 2024

Hi community!

I just found that the Deployment bfe-ingress-controller in the charts has both list and get verbs for the secrets resource (rbac.yaml). However, after reading the source code of ingress-bfe, I didn't find any Kubernetes API usages that require list secrets permissions. If a malicious user gets the service account token, they can list all the names of the secrets, and with the name, they can get the details of all the secrets objects (since this is declared in a ClusterRole). Therefore, for security reasons, I recommend removing this unnecessary permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant