From 90cbf074aa8cda744181887c641d0518b329b4eb Mon Sep 17 00:00:00 2001
From: hornersa <hornersa@plu.edu>
Date: Fri, 21 Feb 2025 07:20:22 -0800
Subject: [PATCH] SAK-51029 Gradebook expected icons missing from grade summary
 (#13333)

---
 .../tool/panels/GradeSummaryTablePanel.html   | 16 ++++-----
 .../modules/tool/gradebook/_gradebook.scss    | 35 +++++++++----------
 2 files changed, 24 insertions(+), 27 deletions(-)

diff --git a/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.html b/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.html
index 2b93afe89d79..2317c58f187f 100644
--- a/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.html
+++ b/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.html
@@ -32,8 +32,8 @@
 								<div class="gb-summary-category-toggle-container">
 									<a href="javascript:void(0);" class="gb-summary-category-toggle" wicket:message="title:studentsummary.categorytoggle"><span wicket:id="category" class="gb-summary-category-name"></span></a>
 									<span class="gb-summary-grade-flags" wicket:id="flags">
-										<span wicket:id="isExtraCredit" class="gb-flag-extra-credit"></span>
-										<span wicket:id="isEqualWeight" class="gb-flag-equal-weight"></span>
+										<span wicket:id="isExtraCredit" class="si gb-flag-extra-credit"></span>
+										<span wicket:id="isEqualWeight" class="si gb-flag-equal-weight"></span>
 									</span>
 								</div>
 								<p wicket:id="categoryDropInfo" class="gb-summary-grade-category-dropInfo">
@@ -53,10 +53,10 @@
 							<span class="gb-summary-grade-title" wicket:id="title"></span>
 							<span><a href="javascript:void(0);" class="gb-summary-grade-stats float-end" wicket:message="title:studentsummary.gradebookitem.assignmentstats" wicket:id="assignmentStatsLink"></a></span>
 							<span class="gb-summary-grade-flags" wicket:id="flags">
-								<span wicket:id="isExtraCredit" class="gb-flag-extra-credit"></span>
-								<span wicket:id="isNotCounted" class="gb-flag-not-counted"></span>
-								<span wicket:id="isNotReleased" class="gb-flag-not-released"></span>
-								<span wicket:id="isExcused" class="gb-flag-excused"></span>
+								<span wicket:id="isExtraCredit" class="si gb-flag-extra-credit"></span>
+								<span wicket:id="isNotCounted" class="si gb-flag-not-counted"></span>
+								<span wicket:id="isNotReleased" class="si gb-flag-not-released"></span>
+								<span wicket:id="isExcused" class="si gb-flag-excused"></span>
 								<span wicket:id="isExternal"></span>
 							</span>
 							<a class="compare-grades-link" href="javascript:void(0);" wicket:message="title:studentsummary.gradebookitem.compare.title" wicket:id="compareLink">
@@ -75,8 +75,8 @@
 							<div>
 								<span wicket:id="categoryName"></span>
 								<span class="gb-summary-grade-category-flags" wicket:id="cflags">
-									<span wicket:id="isExtraCredit" class="gb-flag-extra-credit"></span>
-									<span wicket:id="isEqualWeight" class="gb-flag-equal-weight"></span>
+									<span wicket:id="isExtraCredit" class="si gb-flag-extra-credit"></span>
+									<span wicket:id="isEqualWeight" class="si gb-flag-equal-weight"></span>
 								</span>
 							</div>
 							<p wicket:id="categoryDropInfo" class="gb-summary-grade-category-col-dropInfo">Drop Highest: 1</p>
diff --git a/library/src/skins/default/src/sass/modules/tool/gradebook/_gradebook.scss b/library/src/skins/default/src/sass/modules/tool/gradebook/_gradebook.scss
index e7b6f0642b90..95be173e4fa2 100644
--- a/library/src/skins/default/src/sass/modules/tool/gradebook/_gradebook.scss
+++ b/library/src/skins/default/src/sass/modules/tool/gradebook/_gradebook.scss
@@ -235,13 +235,6 @@
     text-align: center;
     font-style: normal;
   }
-  .gb-flag-not-counted:before {
-    content: '\F1DF';
-    text-decoration-line: line-through;
-  }
-  .gb-flag-not-released:before {
-    content: '\F33F';
-  }
   .gb-flag-counted,
   .gb-flag-released {
     display: none;
@@ -252,12 +245,6 @@
     color:var(--sakai-color-gold--darker-5);
     background-color: var(--sakai-color-gold--lighter-5) !important;
   }
-  .gb-flag-equal-weight:before {
-    content: '\2696';
-  }
-  .gb-flag-extra-credit:before {
-    content: '\F4FC';
-  }
   #gradeTableWrapper .gb-notification.gb-flag-extra-credit:before {
     color:var(--sakai-color-gold--darker-1);
   }
@@ -266,12 +253,7 @@
     color: var(--sakai-text-color-dimmed);
   }
 
-  .gb-flag-excused::before {
-    content: '\F1DF';
-    text-decoration-line: line-through;
-  }
-
-   .gb-flag-external:before {
+  .gb-flag-external:before {
     content: '\F140';
   }
   .gb-flag-read-only:before {
@@ -1675,3 +1657,18 @@ max-height:100px;
 {
   text-decoration: line-through;
 }
+
+.gb-flag-not-counted:before, .gb-flag-excused:before {
+  content: '\F1DF';
+  text-decoration: line-through;
+}
+.gb-flag-not-released:before {
+  content: '\F33F';
+}
+.gb-flag-extra-credit:before {
+  content: '\F4FC';
+}
+.gb-flag-equal-weight:before {
+  content: '\2696';
+}
+