From e01712046a160ee68b0ff9b025987de00bc1b9d8 Mon Sep 17 00:00:00 2001
From: Shiva Lagisetty <67559351+shivalagisetty@users.noreply.github.com>
Date: Tue, 21 Jan 2025 18:28:56 +0530
Subject: [PATCH] feat: NR 328461 add CLS browser golden signals (#1839)

* add: Add cumulative layout shift (75 percentile) metric to golden metrics

* add: Rename cumulative layout shift metric and update summary metrics

* add: Include "NUMBER" as a valid unit in the golden metrics schema

* add: Include "NUMBER" as a valid unit in the summary metrics schema

* fix: Rename cumulative layout shift metric for consistency in golden and summary metrics

* add: Include "NUMBER" as a valid unit in golden and summary metrics schemas

* fix: Remove "NUMBER" as a valid unit from golden and summary metrics schemas

* fix: Update unit from COUNT to NUMBER for cumulative layout shift metric in golden and summary metrics

* fix: Change unit from NUMBER to STRING for cumulative layout shift metric in golden and summary metrics

* fix: Add "STRING" as a valid unit in golden metrics schema

* fix: Change unit from STRING to COUNT for cumulative layout shift metric in golden and summary metrics

* fix: Remove "STRING" from valid units in golden metrics schema

---------

Co-authored-by: Mili <miliborroni@gmail.com>
---
 entity-types/browser-application/golden_metrics.yml  | 8 ++++++++
 entity-types/browser-application/summary_metrics.yml | 4 ++++
 2 files changed, 12 insertions(+)

diff --git a/entity-types/browser-application/golden_metrics.yml b/entity-types/browser-application/golden_metrics.yml
index ee3615dcb..fd55aecc6 100644
--- a/entity-types/browser-application/golden_metrics.yml
+++ b/entity-types/browser-application/golden_metrics.yml
@@ -22,6 +22,14 @@ interactionToNextPaint75PercentileS:
     from: PageViewTiming
     eventId: entityGuid
     eventName: appName
+cumulativeLayoutShift75Percentile:
+  title: Cumulative layout shift (75 percentile)
+  unit: COUNT
+  query:
+    select: percentile(cumulativeLayoutShift, 75)
+    from: PageViewTiming
+    eventId: entityGuid
+    eventName: appName
 errors:
   title: Errors
   unit: COUNT
diff --git a/entity-types/browser-application/summary_metrics.yml b/entity-types/browser-application/summary_metrics.yml
index 4ff6af395..99170f168 100644
--- a/entity-types/browser-application/summary_metrics.yml
+++ b/entity-types/browser-application/summary_metrics.yml
@@ -10,6 +10,10 @@ interactionToNextPaint75PercentileS:
   goldenMetric: interactionToNextPaint75PercentileS
   unit: SECONDS
   title: Interaction to next paint (75 percentile) (s)
+cumulativeLayoutShift75Percentile:
+  goldenMetric: cumulativeLayoutShift75Percentile
+  unit: COUNT
+  title: Cumulative layout shift (75 percentile)
 errors:
   goldenMetric: errors
   unit: COUNT