Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing context string not rendered on async tests #107

Open
kitsu opened this issue May 30, 2016 · 2 comments
Open

Testing context string not rendered on async tests #107

kitsu opened this issue May 30, 2016 · 2 comments
Labels

Comments

@kitsu
Copy link

kitsu commented May 30, 2016

This is pretty minor, but all my testing expressions lose their context div when I make them do async testing. That is the bit of descriptive text between blocks of test results. For Example:

(ns foo.test.stuff
  (:require [cljs.core.async :as ca :refer [<! timeout]])
  (:require-macros [devcards.core :as dc :refer [defcard]]
                   [cljs.test :refer [is testing async]]
                   [cljs.core.async.macros :as async-macros :refer [go]]))

(dc/deftest working-context
  "###Context shown normally"
  (testing "Math identity works"
    (is (= 1 1))))

(dc/deftest async-context
  "###Loss of context when using async"
  (testing "Math identity works"
    (async done
      (go (<! (timeout 10))
            (is (= 1 1))
            (done)))))

The first renders with context (Math identity works), the second doesn't.

;; Relevant
:dependencies [[org.clojure/clojurescript "1.8.51"]
              [org.clojure/core.async "0.2.374" :exclusions [org.clojure/tools.reader]]
              [devcards "0.2.1-7"]]
@bhauman
Copy link
Owner

bhauman commented Jul 25, 2016

Yeah this is a thing ... I'm sure it can be fixed.

@bhauman bhauman added the bug label Jul 25, 2016
@dijonkitchen
Copy link

Any updates or should it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants