Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: componentWillMount has been renamed #163

Open
filipesilva opened this issue Nov 13, 2019 · 0 comments
Open

Warning: componentWillMount has been renamed #163

filipesilva opened this issue Nov 13, 2019 · 0 comments

Comments

@filipesilva
Copy link

Heya,

When devcards is used with newer versions of React, like 16.11.0, the following warning is displayed on the browser console:

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: DevcardBase, HistoryComponent, ReagentInput

printWarning @ react-dom.development.js:12339
lowPriorityWarningWithoutStack @ react-dom.development.js:12360
ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings @ react-dom.development.js:12524
commitRootImpl @ react-dom.development.js:25648
exports.unstable_runWithPriority @ scheduler.development.js:819
runWithPriority$2 @ react-dom.development.js:12131
commitRoot @ react-dom.development.js:24890
performSyncWorkOnRoot @ react-dom.development.js:24297
eval @ react-dom.development.js:12181
exports.unstable_runWithPriority @ scheduler.development.js:819
runWithPriority$2 @ react-dom.development.js:12131
flushSyncCallbackQueueImpl @ react-dom.development.js:12176
flushSyncCallbackQueue @ react-dom.development.js:12164
warnedAboutHydrateAPI @ react-dom.development.js:24391
dispatchDiscreteEvent @ react-dom.development.js:1443

This is similar to reagent-project/reagent#445, addressed by reagent-project/reagent#443.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant