Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snakemake rerun triggers do not check for changes in ped structure and content #455

Open
Nicolai-vKuegelgen opened this issue Oct 13, 2023 · 1 comment

Comments

@Nicolai-vKuegelgen
Copy link
Contributor

Nicolai-vKuegelgen commented Oct 13, 2023

Describe the bug
Sometimes sex information in the (biomedsheet) samplesheet needs to be updated or newly sequenced members are added to a family. This update should also lead to according changes in ped files and and all other relevant files.

To Reproduce
Steps to reproduce the behavior:

  1. Run snappy with sex information (i.e. unknown sex that crashes gcnv)
  2. Update the sex information in the samplesheet
  3. Restart any snappy step that includes the WritePedigreeStepPart (i.e. sv_calling_targeted)
  4. write_pedigree is not rerun

Expected behavior
A change in the input (meta)data should trigger a rerun of all affected downstream files.

Additional context

  • The current input for write_pedigree seems to only include bam files.
  • The rerun triggers for number/set of input files should be re-enabled to catch addition of family members
  • A rerun trigger on params could be used to forward sex changes to snakemake
@Nicolai-vKuegelgen Nicolai-vKuegelgen changed the title Rerun of write_pedigree step is not triggerd when sex infiormation in samplesheet is updated Rerun of write_pedigree step is not triggerd when sex information in samplesheet is updated Oct 13, 2023
@Nicolai-vKuegelgen
Copy link
Contributor Author

Additon: it seems like this extends to other changes of the ped/family structure as well. I.e. addition a new family member will not trigger a re-write of the ped file to include this update.

@Nicolai-vKuegelgen Nicolai-vKuegelgen changed the title Rerun of write_pedigree step is not triggerd when sex information in samplesheet is updated Snakemake rerun triggers do not check for changes in ped structure and content Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant