New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor colour picker #71

Open

billyquith opened this issue Jan 12, 2018 · 1 comment

Labels

improve-refactor priority-low

Owner

billyquith commented Jan 12, 2018

It get controls by name!
It is slow to draw the colour spectrum display as it draws each individual pixel as a rectangle, resulting in needing CTT (see Cache to texture broken for Allegro 5 #27). This colour be replaced with render to pixel buffer and then blit that somehow (new feature).

billyquith added the improve-refactor label

billyquith mentioned this issue

fixed RGB octets showing as characters #70

Merged

Owner Author

billyquith commented Jan 13, 2018

@sfinktah
I should be able to whip you up an actual "HSV" color picker too, I've already had to replicate imgui's conversion routines for HSV and RGB conversion. But hell if I know what I'd call the class. Also, my implementation used integers, not floats, so the range for a HSV value would be [360, 100, 100, 255] (yeah, it doesn't really make a lot of sense, i know) :p

Perhaps there needs to be some color conversion routines. Then each implementation of the color pickers can use these routines.

billyquith added the priority-low label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment