Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to include pixel size/resolution in the spec #499

Closed
petebankhead opened this issue Feb 14, 2023 · 3 comments
Closed

Request to include pixel size/resolution in the spec #499

petebankhead opened this issue Feb 14, 2023 · 3 comments
Milestone

Comments

@petebankhead
Copy link

The topic of including the requested pixel size (resolution) in the model spec came up at the recent HT hackathon.

I wrote a little rant on Zulip about why I think it's important, and at @ctrueden's suggested wanted to include it here.

In summary:

  1. It's extremely common in pathology (and potentially useful elsewhere) to train models from images from a variety of sources, often acquired using different scanners that use different pixel sizes. Rescaling images later to have a standardized pixel size is an effective way to reduce at least one source of variation, and have a model that can potentially generalize well.
  2. It's also extremely common to train models that should be run at different resolutions for different purposes (e.g. 0.5µm/px for nucleus detection, 5µm/px for tumor recognition)

QuPath definitely needs resolution information, but other software does as well - e.g. see

Having the intended resolution as an optional entry in the spec would help avoid more reliance on custom configs.

@FynnBe
Copy link
Member

FynnBe commented Feb 14, 2023

we have discussed quite a bit already and this is the current proposal: #290
@petebankhead it would be great to get your feedback on that!

@petebankhead
Copy link
Author

Sorry, hadn't seen that - I'll think some more, but first impression is that the approach looks good to me!

@FynnBe FynnBe added this to the Release 0.5 milestone Jun 9, 2023
@FynnBe
Copy link
Member

FynnBe commented Mar 18, 2024

unit and scale were added to the axis descriptions in model 0.5

@FynnBe FynnBe closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants