Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corpus Viewer: add numbers to titles when values not unique #482

Closed
PrimozGodec opened this issue Dec 11, 2019 · 1 comment · Fixed by #490
Closed

Corpus Viewer: add numbers to titles when values not unique #482

PrimozGodec opened this issue Dec 11, 2019 · 1 comment · Fixed by #490

Comments

@PrimozGodec
Copy link
Collaborator

As we talked last time there should be numbers beside the titles Corpus Viewer when the title attribute does not have unique values. Numbers must match between different Corpus Viewers even when selection is made.

Probably it needs to be added to the corpus since when we select just a few documents in a widget we lose values of not selected documents.

@PrimozGodec
Copy link
Collaborator Author

PrimozGodec commented Dec 18, 2019

This one is not fixed yet. Maybe my description is not understandable enough. With #481 we just added an option to select the title attribute, but when this attribute has non-unique values there will be no numbers beside in the corpus viewer.

So if we have a title attribute with values:

  • a
  • a
  • b
  • c

We want to see something like this in CorpusViewr (in title section):

  • a (1)
  • a (2)
  • b
  • c

And then when we select two middle rows and pass them to another Corpus Viewer we should have titles:

  • a (2)
  • b

This way we know that we selected the second document with the title a. This will need some modifications in the corpus since we need to remember those numbers in the corpus. I can implement this when I will have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants