noForEach shouldn't be default on

[kurtextrem]

Hi,
noForEach mentions this:

Performance: Using forEach can lead to performance issues, especially when working with large arrays. When more requirements are added on, forEach typically gets chained with other methods like filter or map, causing multiple iterations over the same Array. Encouraging for loops discourages chaining and encourages single-iteration logic (e.g. using a continue instead of filter).

While the latter makes sense, the former doesn't. I've benchmarked forEach vs. for..of using mitata in the latest nodejs (v22), as well as in d8 (v8's debug shell) on the latest version (from source) and bench-node to have a third benchmark source.

Here's the result in d8:

Latest node:

bench-node:

Source: https://github.com/kurtextrem/foreach-bench

So from the benchmarks (m2 Pro laptop), forEach does not seem to be meaningfully slower with large arrays (bench-node result, so guaranteed to be unoptimized), and with mitatas result, forEach even seems slightly faster.

[ematipico]

I think the documentation shouldn't talk about performance for two reasons:

• what you just demonstrated! Thank you very much for taking the time to run these benchmarks
• performance depends on the runtime, and the runtime, with time, is able to improve the performance of certain functions/features

If we removed the "speed" part from the documentation, would you be willing to keep it as recommended?