fix(noTypeOnlyImportAttributes): ignore .cts files #4364
Merged
+64
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4361
noTypeOnlyImportAttributes
reportsimport type
withimport attributes
because this is a syntax error in TypeScript.However, since TypeScript 5.3, this is allowed in CommonJS files.
This PR makes
noTypeOnlyImportAttributes
to ignore files ending the.cts
extension.I notes that the test snapshot outputted the wrong Markdown language (
ts
instead ofcts
). Thus, I changed how we output the Markdown language in tests in order to outputcts
forcts
files. As a side effect this also translatesmts
tocts
. However, we have no test using this extension and this should not create any issue.Test Plan
I added a test.