Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Controlled simulation shutdown #82

Open
okjodom opened this issue Aug 28, 2023 · 1 comment
Open

Feature: Controlled simulation shutdown #82

okjodom opened this issue Aug 28, 2023 · 1 comment
Labels
feature New feature or request

Comments

@okjodom
Copy link
Collaborator

okjodom commented Aug 28, 2023

When shutdown is triggered, we should have a more controlled shutdown of the simulation.

Proposal from @sr-gi

  • First, you stop the producers, so no new payments are passed down the pipeline
  • Then you wait for whatever we feel is reasonable for inflight payments to complete
@carlaKC
Copy link
Contributor

carlaKC commented Aug 28, 2023

Then you wait for whatever we feel is reasonable for inflight payments to complete

Not sure that we'll be able to pick a value for this - for example, testing a scenario where payments get stuck for 2 weeks: where do we shutdown?

I think that a more user-oriented way to approach this could be to have a --wait-for-completion option that they can opt-in to explicitly wait for all actions to exit once they've triggered shutdown (rather than our picking a time that may be opaque to an end user).

@carlaKC carlaKC changed the title Enhancement: Controlled simulation shutdown Feature: Controlled simulation shutdown Aug 28, 2023
@carlaKC carlaKC added the feature New feature or request label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants