Potential Error in Script.isDataOut

[micahriggan]

this.chunks[1].length === this.chunks.len

this line should probably be

this.chunks[1].len === this.chunks.length

bitcore-lib/lib/script/script.js

Line 514 in 8658360

this.chunks[1].length === this.chunks.len));

[matiu]

I am testing this for a valid script, and I get:

console.log('[script.js.465]', this.chunks[1].length , this.chunks.len);

=> undefined, undefined.

So it is wrong it both sides. See tests at:

bitcore-lib/test/script/script.js

Line 268 in 8658360

it('validates that this 40-byte OP_RETURN is standard', function() {

[matiu]

I dont understand the point of that test, I think we should remove it, leaving the line as:

return this.chunks.length >= 1 &&
this.chunks[0].opcodenum === Opcode.OP_RETURN &&
(this.chunks.length === 1 ||
(this.chunks.length === 2 &&
this.chunks[1].buf &&
this.chunks[1].buf.length <= Script.OP_RETURN_STANDARD_SIZE));