Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool connected event #41

Open
braydonf opened this issue Feb 17, 2015 · 2 comments
Open

Pool connected event #41

braydonf opened this issue Feb 17, 2015 · 2 comments

Comments

@braydonf
Copy link
Contributor

When calling pool.connect() there should be an event other than 'peerready' that is emitted, when all connections are filled (as 'ready' can happen before the peer is added to the _connectedPeers object in tests).

var pool = Pool();
pool.on('connected', function() {
  // send message to peers
});
pool.connect();
@maraoz
Copy link
Contributor

maraoz commented Feb 18, 2015

I would call the event 'maxed' or 'full', given most use cases won't care about connecting to ALL peers in a list (thus 'connected' seems misguiding IMO)

@braydonf
Copy link
Contributor Author

Sounds good! fullyconnected perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants