Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitwarden extension UI completely breaks when passkey is attached to a password record #12933

Open
1 task done
elephantchau opened this issue Jan 17, 2025 · 11 comments
Open
1 task done
Labels
browser Browser Extension bug

Comments

@elephantchau
Copy link

elephantchau commented Jan 17, 2025

Steps To Reproduce

https://web.ente.io/

  1. Logged into Ente Web Gallery,

  2. Created a Bitwarden password record (Username and Password only) for Ente,

  3. Initiate the create passkey request on Ente Web Gallery,

  4. Successfully created passkey and attached to that password record we just created,

  5. Click open the Bitwarden plugin and find that record we just created, click into and inspect,

  6. Boom, the UI of Bitwarden gone wild and blank, only with that specific entry.

(High possibility that the data of that entry is corrupted, while other password records are fine)

Expected Result

The UI should act normal (Even if ente.io's passkey implementation might generate unexpected values)

(I have no proof that ente.io's passkey implementation is perfectly fine or defected)

Actual Result

Can't edit, can't even delete that password record using Bitwarden plugin.
The UI would completely brick and unusable. No trash button shown.
Had to login to Bitwarden Web to do the deletion to reset.

Image

Screenshots or Videos

No response

Additional Context

Tested with Chrome and Firefox. Same results.

Operating System

Windows

Operating System Version

Windows 11

Web Browser

Firefox, Chrome

Browser Version

Firefox 134.0.1 (64bit), Chrome 132.0.6834.84 (64Bit)

Build Version

Version: 2024.12.4, SDK: 'main (edee180)', Server: 2025.1.2

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@elephantchau elephantchau added browser Browser Extension bug labels Jan 17, 2025
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-17216

@abergs
Copy link
Member

abergs commented Jan 17, 2025

Thank you for reporting this, I'll take a look...

@abergs
Copy link
Member

abergs commented Jan 20, 2025

@elephantchau Would you be able to re-test this in the 2025.1.0 version?

I can't reproduce it on Version: 2025.1.0, SDK: 'main (28c7e29)'

@elephantchau
Copy link
Author

@abergs I'm unable to update further than 2024.12.4
Tried to check for update but that's the newest version available for the Firefox extension.

@abergs
Copy link
Member

abergs commented Jan 21, 2025

@elephantchau How about on Chrome? Although, I can't replicate the issue on 2024.12.4 on Firefox.

@elephantchau
Copy link
Author

elephantchau commented Jan 21, 2025

@abergs
Tested on Chrome 2025.1.0 SDK: 'main (28c7e29)' Server: 2025.1.2
Same results. The password record was fine until the passkey was created and attached to the record.
Would uBlock Origin extension interfere with Bitwarden?

8Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist.Understand this errorAI
background.js:2 Uncaught (in promise) Error: Duplicate script ID 'fido2-page-script-registration'

console-log.service.ts:53 Unhandled error in angular j: NG02100
    at Kt (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:219795)
    at ee.transform (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:230063)
    at get fido2CredentialCreationDateValue (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/main.js:380:61707)
    at $k (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/main.js:380:59522)
    at tc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:389364)
    at Wc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:398942)
    at Qc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:400308)
    at qc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:400138)
    at Xc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:400069)
    at Wc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:399259)

19
console-log.service.ts:53 Unhandled error in angular j: NG02100
    at Kt (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:219795)
    at ee.transform (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:230063)
    at get fido2CredentialCreationDateValue (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/main.js:380:61707)
    at $k (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/main.js:380:59522)
    at tc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:389364)
    at Wc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:398942)
    at Qc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:400308)
    at qc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:400138)
    at Xc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:400069)
    at Wc (chrome-extension://nngceckbapebfimnlniiiahkandclblb/popup/vendor-angular.js:2:399259)

@abergs
Copy link
Member

abergs commented Jan 22, 2025

Thank you for these logs @elephantchau, we will investigate.

It seems unlikely, but since I don't have uBlock installed but you do it might be relevant if you could distable it and re-test since you can trigger the error repeatedly.

@abergs
Copy link
Member

abergs commented Jan 22, 2025

I did test register with the uBlock extension installed, but still works for me:

Image

@abergs
Copy link
Member

abergs commented Jan 22, 2025

@elephantchau It might also be related to the display language/localization you have. A colleague found this issue which might be related: #6821

@elephantchau
Copy link
Author

@abergs Thanks for the insight. Unfortunately the related issue #6821 happened on web client and not browser extension.
Furthermore, I cannot find a button to change the language/localization on the browser extension. The web client settings for language change was only for the web client and not browser extension.

@elephantchau
Copy link
Author

@abergs
I tested on another machine (Windows 11 VM), with Firefox.
Version: 2024.12.4, SDK: 'main (edee180)' Server version: 2025.1.3
In fact it was totally fine. The system language was English and the browser plugin showed English.

Now I really suspect it was the language/localization problem for the browser plugin.
I can't change the language settings in the browser plugin to test though.
Can devs do some testing with the Traditional Chinese language pack?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

3 participants