From 656f75385206589506604797643982854a9e7e4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ch=C4=99ci=C5=84ski?= Date: Fri, 24 Jan 2025 14:11:52 +0100 Subject: [PATCH] Fix workflow linter detected issues on the workflows (#1210) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## 🎟ī¸ Tracking ## 📔 Objective Fix workflow linter detected issues in the workflows. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## đŸĻŽ Reviewer guidelines - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹī¸ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠ī¸ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or â™ģī¸ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- .github/workflows/build-cli.yml | 6 +++--- .github/workflows/build-cpp.yml | 6 ++++-- .github/workflows/build-dotnet.yml | 2 ++ .github/workflows/build-go.yaml | 2 +- .github/workflows/build-java.yml | 2 ++ .github/workflows/build-napi.yml | 3 ++- .github/workflows/build-python-wheels.yml | 3 ++- .github/workflows/build-ruby.yml | 2 +- .github/workflows/build-rust-crates.yml | 10 +++++----- .../workflows/build-rust-cross-platform.yml | 3 ++- .github/workflows/direct-minimal-versions.yml | 4 ++-- .github/workflows/lint.yml | 2 +- .github/workflows/minimum-rust-version.yml | 4 ++-- .github/workflows/publish-bws.yml | 18 +++++++++--------- .github/workflows/publish-dotnet.yml | 4 ++-- .github/workflows/publish-napi.yml | 12 ++++++------ .github/workflows/publish-ruby.yml | 12 ++++++------ .github/workflows/publish-rust-crates.yml | 12 ++++++------ .github/workflows/publish-wasm.yml | 8 ++++---- .github/workflows/release-bws.yml | 2 +- .github/workflows/release-napi.yml | 2 +- .github/workflows/release-rust-crates.yml | 2 +- .github/workflows/release-wasm.yml | 6 +++--- .github/workflows/rust-test.yml | 3 ++- .github/workflows/rustdoc.yml | 4 ++-- 25 files changed, 72 insertions(+), 62 deletions(-) diff --git a/.github/workflows/build-cli.yml b/.github/workflows/build-cli.yml index 0450a5148..9d009fa0e 100644 --- a/.github/workflows/build-cli.yml +++ b/.github/workflows/build-cli.yml @@ -40,7 +40,7 @@ jobs: build-windows: name: Building CLI for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }} - runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }} + runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }} needs: setup env: _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }} @@ -128,7 +128,7 @@ jobs: build-macos: name: Building CLI for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }} - runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }} + runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }} needs: setup env: _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }} @@ -237,7 +237,7 @@ jobs: build-linux: name: Building CLI for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }} - runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }} + runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }} needs: setup env: _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }} diff --git a/.github/workflows/build-cpp.yml b/.github/workflows/build-cpp.yml index fcc64b2c7..b76851aac 100644 --- a/.github/workflows/build-cpp.yml +++ b/.github/workflows/build-cpp.yml @@ -12,9 +12,11 @@ on: jobs: generate-schemas: + name: Generate schemas uses: ./.github/workflows/generate_schemas.yml build_rust: + name: Build Rust uses: ./.github/workflows/build-rust-cross-platform.yml build: @@ -43,13 +45,13 @@ jobs: - name: Checkout Repository uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - - name: install dependencies linux + - name: Install dependencies linux if: runner.os == 'Linux' run: | sudo apt-get install -y nlohmann-json3-dev sudo apt-get install -y libboost-all-dev - - name: install dependencies macos + - name: Install dependencies macos if: runner.os == 'macOS' run: | brew install nlohmann-json diff --git a/.github/workflows/build-dotnet.yml b/.github/workflows/build-dotnet.yml index 64c2366f7..09026c6b3 100644 --- a/.github/workflows/build-dotnet.yml +++ b/.github/workflows/build-dotnet.yml @@ -11,9 +11,11 @@ on: jobs: generate_schemas: + name: Generate schemas uses: ./.github/workflows/generate_schemas.yml build_rust: + name: Build Rust uses: ./.github/workflows/build-rust-cross-platform.yml version: diff --git a/.github/workflows/build-go.yaml b/.github/workflows/build-go.yaml index aa4c421c0..5f3426212 100644 --- a/.github/workflows/build-go.yaml +++ b/.github/workflows/build-go.yaml @@ -34,7 +34,7 @@ jobs: restore-keys: | ${{ runner.os }}-go- - - name: npm ci + - name: Run npm ci run: npm ci - name: Generate schemas diff --git a/.github/workflows/build-java.yml b/.github/workflows/build-java.yml index 63b08eb1c..e0b9fcb97 100644 --- a/.github/workflows/build-java.yml +++ b/.github/workflows/build-java.yml @@ -9,9 +9,11 @@ on: jobs: generate_schemas: + name: Generate schemas uses: ./.github/workflows/generate_schemas.yml build_rust: + name: Build Rust uses: ./.github/workflows/build-rust-cross-platform.yml build_java: diff --git a/.github/workflows/build-napi.yml b/.github/workflows/build-napi.yml index 09eb8ca76..820e80df7 100644 --- a/.github/workflows/build-napi.yml +++ b/.github/workflows/build-napi.yml @@ -16,11 +16,12 @@ defaults: jobs: generate_schemas: + name: Generate schemas uses: ./.github/workflows/generate_schemas.yml build: name: Building @bitwarden/sdk-napi for - ${{ matrix.settings.os }} - runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }} + runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }} needs: generate_schemas strategy: fail-fast: false diff --git a/.github/workflows/build-python-wheels.yml b/.github/workflows/build-python-wheels.yml index ad58d8701..617d97e51 100644 --- a/.github/workflows/build-python-wheels.yml +++ b/.github/workflows/build-python-wheels.yml @@ -16,6 +16,7 @@ defaults: jobs: generate_schemas: + name: Generate schemas uses: ./.github/workflows/generate_schemas.yml setup: @@ -35,7 +36,7 @@ jobs: build: name: Building Python wheel for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }} - runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }} + runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }} needs: - generate_schemas - setup diff --git a/.github/workflows/build-ruby.yml b/.github/workflows/build-ruby.yml index 2c2089749..6e15a6cbe 100644 --- a/.github/workflows/build-ruby.yml +++ b/.github/workflows/build-ruby.yml @@ -79,7 +79,7 @@ jobs: cp "temp/${platforms[$i]}/${files[$i]}" "languages/ruby/bitwarden_sdk_secrets/lib/${platforms[$i]}/${files[$i]}" done - - name: bundle install + - name: Run bundle install run: bundle install working-directory: languages/ruby/bitwarden_sdk_secrets diff --git a/.github/workflows/build-rust-crates.yml b/.github/workflows/build-rust-crates.yml index a76fb5b60..e876b4e0a 100644 --- a/.github/workflows/build-rust-crates.yml +++ b/.github/workflows/build-rust-crates.yml @@ -14,15 +14,15 @@ jobs: build: name: Building ${{matrix.package}} for - ${{ matrix.os }} - runs-on: ${{ matrix.os || 'ubuntu-latest' }} + runs-on: ${{ matrix.os || 'ubuntu-24.04' }} strategy: fail-fast: false matrix: os: - - macos-latest - - ubuntu-latest - - windows-latest + - macos-13 + - ubuntu-24.04 + - windows-2022 package: - bitwarden @@ -46,7 +46,7 @@ jobs: release-dry-run: name: Release dry-run - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 if: ${{ github.ref == 'refs/head/main' }} needs: build steps: diff --git a/.github/workflows/build-rust-cross-platform.yml b/.github/workflows/build-rust-cross-platform.yml index 1b3f8e093..b7adec4e9 100644 --- a/.github/workflows/build-rust-cross-platform.yml +++ b/.github/workflows/build-rust-cross-platform.yml @@ -48,8 +48,9 @@ jobs: - name: Cache cargo registry uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5 - - uses: goto-bus-stop/setup-zig@abea47f85e598557f500fa1fd2ab7464fcb39406 # v2.2.1 + - name: Install Zig if: ${{ contains(matrix.settings.target, 'musl') }} + uses: goto-bus-stop/setup-zig@abea47f85e598557f500fa1fd2ab7464fcb39406 # v2.2.1 with: version: 0.12.0 diff --git a/.github/workflows/direct-minimal-versions.yml b/.github/workflows/direct-minimal-versions.yml index 5c7fdd705..b2de51256 100644 --- a/.github/workflows/direct-minimal-versions.yml +++ b/.github/workflows/direct-minimal-versions.yml @@ -16,7 +16,7 @@ defaults: jobs: direct-minimal-versions: name: Check dependencies minimal versions for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }} - runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }} + runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }} strategy: fail-fast: false matrix: @@ -48,5 +48,5 @@ jobs: with: key: dmv-${{ matrix.settings.target }}-cargo-${{ matrix.settings.os }} - - name: cargo check direct-minimal-versions + - name: Run cargo check direct-minimal-versions run: cargo check -Z direct-minimal-versions --all-features diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 8b2bc7c86..5fa95c0df 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -13,7 +13,7 @@ jobs: style: name: Check Style - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Checkout diff --git a/.github/workflows/minimum-rust-version.yml b/.github/workflows/minimum-rust-version.yml index 5eb7c39e7..a0e1defb6 100644 --- a/.github/workflows/minimum-rust-version.yml +++ b/.github/workflows/minimum-rust-version.yml @@ -16,7 +16,7 @@ defaults: jobs: msrv: name: Check MSRV for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }} - runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }} + runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }} strategy: fail-fast: false matrix: @@ -41,5 +41,5 @@ jobs: with: key: msrv-${{ matrix.settings.target }}-cargo-${{ matrix.settings.os }} - - name: cargo check MSRV + - name: Run cargo check MSRV run: cargo check -p bitwarden --all-features diff --git a/.github/workflows/publish-bws.yml b/.github/workflows/publish-bws.yml index 53fd9f67d..4a04c3406 100644 --- a/.github/workflows/publish-bws.yml +++ b/.github/workflows/publish-bws.yml @@ -26,9 +26,9 @@ jobs: name: Setup runs-on: ubuntu-22.04 outputs: - release-version: ${{ steps.version-output.outputs.version }} - release-tag: ${{ steps.version-output.outputs.tag_name }} - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + release_version: ${{ steps.version-output.outputs.version }} + release_tag: ${{ steps.version-output.outputs.tag_name }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} steps: - name: Checkout repo uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -75,8 +75,8 @@ jobs: runs-on: ubuntu-22.04 needs: setup env: - _VERSION: ${{ needs.setup.outputs.release-version }} - _TAG_NAME: ${{ needs.setup.outputs.release-tag }} + _VERSION: ${{ needs.setup.outputs.release_version }} + _TAG_NAME: ${{ needs.setup.outputs.release_tag }} steps: - name: Checkout uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -129,7 +129,7 @@ jobs: - name: Generate tag list id: tag-list env: - VERSION: ${{ needs.setup.outputs.release-version }} + VERSION: ${{ needs.setup.outputs.release_version }} DRY_RUN: ${{ inputs.release_type == 'Dry Run' }} run: | if [[ "${DRY_RUN}" == "true" ]]; then @@ -228,7 +228,7 @@ jobs: needs: setup if: ${{ inputs.release_type != 'Dry Run' }} env: - _DEPLOYMENT_ID: ${{ needs.setup.outputs.deployment-id }} + _DEPLOYMENT_ID: ${{ needs.setup.outputs.deployment_id }} steps: - name: Update deployment status to Success if: ${{ inputs.release_type != 'Dry Run' && success() }} @@ -236,7 +236,7 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "success" - deployment-id: ${{ env._DEPLOYMENT_ID }} + deployment_id: ${{ env._DEPLOYMENT_ID }} - name: Update deployment status to Failure if: ${{ inputs.release_type != 'Dry Run' && failure() }} @@ -244,4 +244,4 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "failure" - deployment-id: ${{ env._DEPLOYMENT_ID }} + deployment_id: ${{ env._DEPLOYMENT_ID }} diff --git a/.github/workflows/publish-dotnet.yml b/.github/workflows/publish-dotnet.yml index d7543846b..f54484cc8 100644 --- a/.github/workflows/publish-dotnet.yml +++ b/.github/workflows/publish-dotnet.yml @@ -102,7 +102,7 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "success" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} - name: Update deployment status to Failure if: ${{ inputs.release_type != 'Dry Run' && failure() }} @@ -110,4 +110,4 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "failure" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} diff --git a/.github/workflows/publish-napi.yml b/.github/workflows/publish-napi.yml index 3761f5318..f3a1d9e52 100644 --- a/.github/workflows/publish-napi.yml +++ b/.github/workflows/publish-napi.yml @@ -26,8 +26,8 @@ jobs: name: Setup runs-on: ubuntu-22.04 outputs: - release-version: ${{ steps.version-output.outputs.version }} - tag-name: ${{ steps.version-output.outputs.tag_name }} + release_version: ${{ steps.version-output.outputs.version }} + tag_name: ${{ steps.version-output.outputs.tag_name }} steps: - name: Checkout repo uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -63,8 +63,8 @@ jobs: runs-on: ubuntu-22.04 needs: setup env: - _PKG_VERSION: ${{ needs.setup.outputs.release-version }} - _TAG_NAME: ${{ needs.setup.outputs.tag-name }} + _PKG_VERSION: ${{ needs.setup.outputs.release_version }} + _TAG_NAME: ${{ needs.setup.outputs.tag_name }} steps: - name: Checkout repo uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -143,7 +143,7 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "success" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} - name: Update deployment status to Failure if: ${{ inputs.release_type != 'Dry Run' && failure() }} @@ -151,4 +151,4 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "failure" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} diff --git a/.github/workflows/publish-ruby.yml b/.github/workflows/publish-ruby.yml index edbf23bca..4af7b1f2d 100644 --- a/.github/workflows/publish-ruby.yml +++ b/.github/workflows/publish-ruby.yml @@ -26,8 +26,8 @@ jobs: name: Setup runs-on: ubuntu-22.04 outputs: - release-version: ${{ steps.version-output.outputs.version }} - tag-name: ${{ steps.version-output.outputs.tag_name }} + release_version: ${{ steps.version-output.outputs.version }} + tag_name: ${{ steps.version-output.outputs.tag_name }} steps: - name: Checkout Repository uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -63,8 +63,8 @@ jobs: runs-on: ubuntu-22.04 needs: setup env: - _VERSION: ${{ needs.setup.outputs.release-version }} - _TAG_NAME: ${{ needs.setup.outputs.tag-name }} + _VERSION: ${{ needs.setup.outputs.release_version }} + _TAG_NAME: ${{ needs.setup.outputs.tag_name }} steps: - name: Checkout Repository uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -115,7 +115,7 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "success" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} - name: Update deployment status to Failure if: ${{ inputs.release_type != 'Dry Run' && failure() }} @@ -123,4 +123,4 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "failure" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} diff --git a/.github/workflows/publish-rust-crates.yml b/.github/workflows/publish-rust-crates.yml index 78deb2ae5..f41a3c8fe 100644 --- a/.github/workflows/publish-rust-crates.yml +++ b/.github/workflows/publish-rust-crates.yml @@ -21,11 +21,11 @@ on: jobs: setup: - name: setup + name: Setup runs-on: ubuntu-22.04 outputs: - release-version: ${{ steps.version-output.outputs.version }} - release-tag: ${{ steps.version-output.outputs.tag_name }} + release_version: ${{ steps.version-output.outputs.version }} + release_tag: ${{ steps.version-output.outputs.tag_name }} steps: - name: Checkout uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -64,7 +64,7 @@ jobs: - name: Checkout uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: - ref: ${{ needs.setup.outputs.release-tag }} + ref: ${{ needs.setup.outputs.release_tag }} - name: Login to Azure uses: Azure/login@e15b166166a8746d1a47596803bd8c1b595455cf # v1.6.0 @@ -113,7 +113,7 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "success" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} - name: Update deployment status to Failure if: ${{ inputs.release_type != 'Dry Run' && failure() }} @@ -121,4 +121,4 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "failure" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} diff --git a/.github/workflows/publish-wasm.yml b/.github/workflows/publish-wasm.yml index 8da55fe3f..06213def8 100644 --- a/.github/workflows/publish-wasm.yml +++ b/.github/workflows/publish-wasm.yml @@ -26,7 +26,7 @@ jobs: name: Setup runs-on: ubuntu-22.04 outputs: - release-version: ${{ steps.version-output.outputs.version }} + release_version: ${{ steps.version-output.outputs.version }} tag_name: ${{ steps.version-output.outputs.tag_name }} steps: - name: Checkout repo @@ -63,7 +63,7 @@ jobs: runs-on: ubuntu-22.04 needs: setup env: - _VERSION: ${{ needs.setup.outputs.release-version }} + _VERSION: ${{ needs.setup.outputs.release_version }} steps: - name: Checkout repo uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -126,7 +126,7 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "success" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} - name: Update deployment status to Failure if: ${{ inputs.release_type != 'Dry Run' && failure() }} @@ -134,4 +134,4 @@ jobs: with: token: "${{ secrets.GITHUB_TOKEN }}" state: "failure" - deployment-id: ${{ steps.deployment.outputs.deployment_id }} + deployment_id: ${{ steps.deployment.outputs.deployment_id }} diff --git a/.github/workflows/release-bws.yml b/.github/workflows/release-bws.yml index 970c06545..0e81b0b25 100644 --- a/.github/workflows/release-bws.yml +++ b/.github/workflows/release-bws.yml @@ -18,7 +18,7 @@ jobs: name: Setup runs-on: ubuntu-22.04 outputs: - release-version: ${{ steps.version.outputs.version }} + release_version: ${{ steps.version.outputs.version }} steps: - name: Checkout repo uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 diff --git a/.github/workflows/release-napi.yml b/.github/workflows/release-napi.yml index 70ddd6f10..682f923dd 100644 --- a/.github/workflows/release-napi.yml +++ b/.github/workflows/release-napi.yml @@ -41,7 +41,7 @@ jobs: - name: Check Release Version id: version - uses: bitwarden/gh-actions/release-version-check@main + uses: bitwarden/gh-actions/release_version-check@main with: release-type: ${{ inputs.release_type }} project-type: ts diff --git a/.github/workflows/release-rust-crates.yml b/.github/workflows/release-rust-crates.yml index fdf5f7ad6..83ad5cb58 100644 --- a/.github/workflows/release-rust-crates.yml +++ b/.github/workflows/release-rust-crates.yml @@ -18,7 +18,7 @@ jobs: name: Setup runs-on: ubuntu-22.04 outputs: - release-version: ${{ steps.version.outputs.version }} + release_version: ${{ steps.version.outputs.version }} steps: - name: Checkout repo uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 diff --git a/.github/workflows/release-wasm.yml b/.github/workflows/release-wasm.yml index 0af0f5739..c2b038594 100644 --- a/.github/workflows/release-wasm.yml +++ b/.github/workflows/release-wasm.yml @@ -22,7 +22,7 @@ jobs: name: Setup runs-on: ubuntu-22.04 outputs: - release-version: ${{ steps.version.outputs.version }} + release_version: ${{ steps.version.outputs.version }} steps: - name: Checkout repo uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -39,7 +39,7 @@ jobs: - name: Check Release Version id: version - uses: bitwarden/gh-actions/release-version-check@main + uses: bitwarden/gh-actions/release_version-check@main with: release-type: ${{ inputs.release_type }} project-type: ts @@ -66,7 +66,7 @@ jobs: if: ${{ inputs.release_type != 'Dry Run' }} uses: ncipollo/release-action@2c591bcc8ecdcd2db72b97d6147f871fcd833ba5 # v1.14.0 env: - PKG_VERSION: ${{ needs.setup.outputs.release-version }} + PKG_VERSION: ${{ needs.setup.outputs.release_version }} with: commit: ${{ github.sha }} tag: wasm-v${{ env.PKG_VERSION }} diff --git a/.github/workflows/rust-test.yml b/.github/workflows/rust-test.yml index bfe841a4d..d3cc1a399 100644 --- a/.github/workflows/rust-test.yml +++ b/.github/workflows/rust-test.yml @@ -18,7 +18,8 @@ jobs: - test - wasm steps: - - run: exit 0 + - name: Exit 0 + run: exit 0 test: name: ${{ matrix.os }} / default diff --git a/.github/workflows/rustdoc.yml b/.github/workflows/rustdoc.yml index 699f1ead1..eea1beff3 100644 --- a/.github/workflows/rustdoc.yml +++ b/.github/workflows/rustdoc.yml @@ -16,7 +16,7 @@ concurrency: jobs: rustdoc: name: Rustdoc - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Checkout @@ -41,7 +41,7 @@ jobs: environment: name: github-pages url: ${{ steps.deployment.outputs.page_url }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: rustdoc name: Deploy steps: