Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile friendly layout #1255

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pmpinto
Copy link

@pmpinto pmpinto commented Jan 30, 2025

Closes #1251


This reworks the tablerow.html include file so that:

  • Images aren't squished;
  • Product names are slightly bigger;
  • Model numbers are slightly smaller;
  • Product names, model numbers and compatibility icons appear on top of each other, and…
  • … images take up 3 rows so that they align with the product details;
  • It can now be included everywhere by default and the compatibility icons get hidden if the hide_compat variable is present (⚠️ This means the tablerow_nocompatibility.html file should now be safe to delete. I didn't, but feel free to ask for it.)

This PR will also fix the non-scrolling mobile navigation.
And will also allow more vertical space for the affiliate disclaimer text in the navigation on large layouts — it was partially hidden.
Lastly, it replaces the non-existent HTML element sidebar with nav which represents a navigation.

@blakadder please take a look at this when you can and let me know if you would like some tweaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile layout looks broken
1 participant