Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support camera-specific hwaccel_args for Timelapse export #12758

Open
aroberts opened this issue Aug 4, 2024 · 0 comments
Open

Support camera-specific hwaccel_args for Timelapse export #12758

aroberts opened this issue Aug 4, 2024 · 0 comments
Labels
enhancement New feature or request pinned

Comments

@aroberts
Copy link

aroberts commented Aug 4, 2024

Describe what you are trying to accomplish and why in non technical terms
Timelapse export hardware acceleration is driven by the global ffmpeg.hwaccel_args config, as well as several other things. I have one camera that is not able to export using these settings, because the resolution is greater than the max allowed by my igpu under vaapi. I'd like to be able to override the global ffmpeg hwaccel args for that camera (to empty, in my case, but it should allow any args) for Timelapse export, so I don't have to globally disable hardware acceleration

Describe the solution you'd like
add optional camera config key record.export.hwaccel_args (alongside timelapse_args), with a default value of "auto" which would mean the value stored in [camera].hwaccel_args (which in turn defaults to the global hwaccel_args). From there, the export ffmpeg construction line here can instead look at the camera-specific config, as it does for timelapse_args.

Describe alternatives you've considered
Removing the global hwaccel_args and instead assigning it per-camera appears to have consequences for other features (Birdseye, for example, appears to also use the global setting with no way to override), as well as being more config to manage.

@aroberts aroberts added the enhancement New feature or request label Aug 4, 2024
@NickM-27 NickM-27 added the pinned label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

No branches or pull requests

2 participants