Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Author names have spaces all over the shop #202

Open
rabdill opened this issue Oct 14, 2018 · 2 comments
Open

Author names have spaces all over the shop #202

rabdill opened this issue Oct 14, 2018 · 2 comments
Labels
bug Something isn't working spider Issue with the web crawler
Milestone

Comments

@rabdill
Copy link
Collaborator

rabdill commented Oct 14, 2018

Strip out leading/trailing spaces and multiple spaces between words before recording the name AND before checking for whether the author exists before making a new one

Then go back and check if we can merge any authors that have identical names when the spaces are gone

@rabdill rabdill added bug Something isn't working spider Issue with the web crawler labels Oct 14, 2018
@rabdill rabdill added this to the 0.8 milestone Oct 14, 2018
@rabdill
Copy link
Collaborator Author

rabdill commented Oct 14, 2018

Save the merging function so we can do this in the future for other stuff, like merging authors who have identical names if you remove all the periods

@rabdill
Copy link
Collaborator Author

rabdill commented Oct 17, 2018

Couldn't actually find any names with leading/trailing spaces, and only about 1,420 with two+ spaces in the middle of a name. Pushing back to later

@rabdill rabdill modified the milestones: 0.8, 1.2 Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working spider Issue with the web crawler
Projects
None yet
Development

No branches or pull requests

1 participant