Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify not available on wasm #460

Open
DruggedBunny opened this issue Jan 19, 2019 · 5 comments
Open

Notify not available on wasm #460

DruggedBunny opened this issue Jan 19, 2019 · 5 comments

Comments

@DruggedBunny
Copy link

Just tried to build on wasm and found Notify isn't available, not sure if intentional...

Mx2cc version 1.1.15

***** Making app 'D:/Documents/Development/Sources/Monkey2 Sources/speccy island/speccy_island.monkey2' (emscripten release llvm gcc) *****

Parsing...
Semanting...
D:/Documents/Development/Sources/Monkey2 Sources/speccy island/retrofx.monkey2 [38] : Error : Identifier 'Notify' Not found

@engor
Copy link
Contributor

engor commented Jan 19, 2019

This function is under std.requesters namespace, if you jump to definition you'll see that only OpenUrl() is available for Emscripten target.
So it's not a bug, but maybe there should be some replacement.

@DruggedBunny
Copy link
Author

Yeah, probably not a bug, just unimplemented; I hacked in a TARGET check to work around it.

(On the topic of wasm, I've just noticed that although all assets get bundled into a project.data file, it still creates an empty assets folder that seems not to be necessary.)

@seyhajin
Copy link
Contributor

seyhajin commented Jun 4, 2019

'Notify' is only for Desktop target, use 'OpenURL' for emscripten.
Issue can be closed.

@nitrologic
Copy link

Is window.alert() not available for this purpose?

@seyhajin
Copy link
Contributor

seyhajin commented Jun 4, 2019

Apparently this causes popup warnings from the browser, see 6fcdfbb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants