Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is @VerbClient desired? #4635

Closed
bradleydwyer opened this issue Feb 25, 2025 · 2 comments
Closed

Is @VerbClient desired? #4635

bradleydwyer opened this issue Feb 25, 2025 · 2 comments
Assignees

Comments

@bradleydwyer
Copy link
Collaborator

The behaviour of Kotlin for generating client impls within a module is different to Go (manual declaration vs automatic). Is this intentional?

@github-actions github-actions bot added the triage Issue needs triaging label Feb 25, 2025
@stuartwdouglas
Copy link
Collaborator

There is an issue for it, it needs to be done via annotation processors to work correctly.

I also don't know how much actual demand there is for invoking verbs within the same module (other than SQL verbs, which are different), which is why I have not really prioritized this.

@stuartwdouglas
Copy link
Collaborator

I could probably actually just have a client that looks like convert: LocalClient<ConvertRequest>, this is still type safe, but it avoids needed to define a new class, and the build would fail if there is no 'convert' verb locally.

@github-actions github-actions bot removed the triage Issue needs triaging label Mar 3, 2025
@alecthomas alecthomas closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants