Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display empty NFT attributes #2337

Open
yvaskov opened this issue Oct 29, 2024 · 0 comments · May be fixed by #2348
Open

Do not display empty NFT attributes #2337

yvaskov opened this issue Oct 29, 2024 · 0 comments · May be fixed by #2348
Assignees
@tom2drum
Labels
bug Something isn't working

Comments

@yvaskov
Copy link
Collaborator

yvaskov commented Oct 29, 2024

Description

If an NFT instance attribute value is empty, we should hide the relevant attribute badge in the UI.

{
    "trait_type": "animation_url",
    "value": ""
},
{
    "trait_type": "animation_url_mime_type",
    "value": ""
}

Image

Example

https://explorer.immutable.com/token/0x6bC8e19599D570ec6e6163f0C8858deC6B992ad0/instance/1385789

Version

v1.35.2
@yvaskov yvaskov added the bug Something isn't working label Oct 29, 2024
@tom2drum tom2drum self-assigned this Oct 31, 2024
tom2drum added a commit that referenced this issue Oct 31, 2024
@tom2drum
Do not display empty NFT attributes
9dccf19 
Fixes #2337
@tom2drum tom2drum linked a pull request Oct 31, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tom2drum tom2drum

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not display empty NFT attributes blockscout/frontend
2 participants
@tom2drum @yvaskov