Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Backport to 1.19.X #22

Open
SK1Y101 opened this issue Mar 19, 2024 · 9 comments
Open

[Request] Backport to 1.19.X #22

SK1Y101 opened this issue Mar 19, 2024 · 9 comments
Labels
enhancement New feature or request fixed-at-dev This problem is already fixed on the development branch

Comments

@SK1Y101
Copy link

SK1Y101 commented Mar 19, 2024

I'm currently playing 1.19.2, and am really missing this functionality. Would greatly appreciate a backport if possible.

@ftrless
Copy link
Contributor

ftrless commented Mar 21, 2024

Working on it right now, once it's done and minimally tested I'll do pr here

@SK1Y101
Copy link
Author

SK1Y101 commented Mar 21, 2024

That's awesome! Thank you so much

@ftrless
Copy link
Contributor

ftrless commented Mar 21, 2024

https://github.com/Ftrless/ae2-emi-crafting/tree/1.19

It seems to be working properly

@roridev need branch to merge :)

@alikindsys
Copy link
Contributor

I will pull those changes into a new branch once I get home, just keep that branch alive and do any changes you need to

@alikindsys
Copy link
Contributor

Is Shift+RMB supposed to do anything on EMI?, IIRC only Shift+LMB fills the recipe.

@ftrless
Copy link
Contributor

ftrless commented Mar 25, 2024

Oh, yeah, LMB

@alikindsys
Copy link
Contributor

alikindsys commented Mar 25, 2024

Yeah, there is no easy way to fix that. EMI will happily request ae2 for every single possible recipe on the item list, which causes a lot of lag (#23).

EMI would need to add another context for shift clicking the recipe or make that action trigger the same context as FILL_RECIPE.

For now Shift+LMB will be broken until I submit a patch for EMI, which likely will take some time and emily would need to accept that.

Other then that, yeah. I have 1.19 working on a local branch and will publish the version on modrinth/cf soon.

@alikindsys
Copy link
Contributor

Fixed

Dev: 74d844e
MR: Waiting for release
CF: Waiting for release

@alikindsys alikindsys added enhancement New feature or request fixed-at-dev This problem is already fixed on the development branch labels Mar 25, 2024
@Slayer5934
Copy link

Looking forward to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed-at-dev This problem is already fixed on the development branch
Projects
None yet
Development

No branches or pull requests

4 participants