Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Profile not found" on appview after account was deleted and then restored #3455

Open
ledlamp opened this issue Jan 24, 2025 · 2 comments
Open
Labels
bug Something isn't working

Comments

@ledlamp
Copy link

ledlamp commented Jan 24, 2025

This account is broken on the Bluesky appview: https://bsky.app/profile/did:plc:jhecgykhbxj4nvvqrtv5rtww

However the did doc, PDS and repository are all valid: https://atproto-browser.vercel.app/at/did:plc:jhecgykhbxj4nvvqrtv5rtww

This is what happened:

  1. Person tried to migrate from Bluesky PDS to their own PDS but failed part-way, missing blobs
  2. Person deleted the account from the PDS to try to start over
  3. I helped create the new account again, deactivate the old account, complete the migration, and correct the did doc

Everything is valid now, but the profile still gets "Profile not found" on the Bluesky application. I've tried deactivating and reactivating the account, but it seems like the appview (or the relay?) won't restore the account.

I guess what happened is that deleting the account (which matched the did doc's public key) submitted an event that told the appview/relay that the account was permanently deleted, and now it doesn't do anything with updates from an account that was supposed to not exist anymore.

@ledlamp ledlamp added the bug Something isn't working label Jan 24, 2025
@ledlamp
Copy link
Author

ledlamp commented Jan 24, 2025

Here is a way to reproduce:

  1. Migrate a bsky.social account to your own PDS with goat account migrate
  2. Delete the account with pdsadmin.sh account delete <did>
  3. Revert changes to the DID doc using https://boat.kelinci.net/plc-applicator and the key from your PDS
  4. Log in to the original account and activate it again

What should happen:

The relay/appview should resync the account when it activates and everything should work normally again.

What actually happens:

The Bluesky app continues to say "Profile not found" despite the did doc and repository being all valid. The Bluesky chat says "account is suspended".

@ygg2
Copy link

ygg2 commented Jan 27, 2025

This looks like a very important issue since a malicious PDS could delete users who then couldn't recover their accounts despite recovering their identities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants