Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projection, Configuration and Start Document Metadata #608

Open
dylanmcreynolds opened this issue Oct 1, 2020 · 1 comment
Open

Projection, Configuration and Start Document Metadata #608

dylanmcreynolds opened this issue Oct 1, 2020 · 1 comment
Assignees
Labels

Comments

@dylanmcreynolds
Copy link
Contributor

The initial version of the projector contains a misunderstanding of the event-model documents structure.

I took the techniques PR from @tacaswell and implemnted "configuration" types as metadata from the run start document. I believe now that this was intended to be fields from the configuration section of the even descriptor document, which contains fields stored once per scan per stream.

I believe that projections should support both. So, I propose to change/enhance this soon.

@dylanmcreynolds dylanmcreynolds self-assigned this Oct 1, 2020
@dylanmcreynolds
Copy link
Contributor Author

dylanmcreynolds commented Oct 23, 2020

I recently added a value field to to projections to support the static type. This type will let you defined a field and value in the projection, which will be added the resulting Dataset, directly. This was added to the event-model run_start schema (see bluesky/event-model#194)

Question though: when projecting this field into an xarray.Dataset, is there a default location that it should go into? Should the schema require that a location also be added so that the projector can treat it like one of:

  • metadata
  • event configuration
  • event field

Or would it just go in the metadata? I'm sure I know the answer, but wanted to check with @ronpandolfi.

Not particularly germane to this PR but I'd like to sneak it in if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant