[CLOSED] No connections are drawn when opening a Yarn file

[desplesda]

Issue by swakdaddy
Friday Aug 24, 2018 at 15:06 GMT
Originally opened as InfiniteAmmoInc/Yarn#78

---

OS: Windows 10.

Repro steps:

• Open Yarn version 0.2.1 for Windows.
• File -> Open -> Sally.yarn.txt
• Observe Yarn load the nodes, but draw no connections between nodes.

Including a file I know isn't working.

Thanks!

Sally.yarn.txt

[desplesda]

Comment by julsam
Saturday Aug 25, 2018 at 12:16 GMT

---

Thank you for your reporting this bug 👍

It seems like the issue comes from the line ending. When using the yarn.txt save format, Yarn is expecting only Unix type line ending and doesn't interpret correctly CR that Windows add. By default Yarn saves using LF only, but I guess the text editor you used changed it to CRLF.

Should be easy to fix, but in the meantime you can convert your files from the Windows format to the Unix one and the connections should be back 😉
Here's your file converted: Sally.yarn.txt

Another quickfix would be to save it as a json file.

[desplesda]

Comment by swakdaddy
Saturday Aug 25, 2018 at 15:01 GMT

---

Thanks for the great info and the source of the problem.
I'm not sure what editor added CR. I only used Notepad++ and Visual Studio 2017.
I just tested editing/saving with whitespace visible and neither added CR.
I'll be sure to keep an eye out in the future.

Thank you! :-)

[desplesda]

Comment by blurymind
Saturday Nov 24, 2018 at 10:25 GMT

---

ok I fixed this bug in my pull here:
InfiniteAmmoInc/Yarn#80
InfiniteAmmoInc/Yarn@1cc7e50

[desplesda]

Comment by blurymind
Monday Nov 26, 2018 at 12:24 GMT

---

this is actually fixed in #79 , so I reverted my fix in #80

[desplesda]

Comment by desplesda
Monday Jan 21, 2019 at 09:32 GMT

---

Fixed in c50b77c.

[desplesda]

Comment by swakdaddy
Friday Apr 12, 2019 at 01:29 GMT

---

So I noticed that this fix doesn't seem to be included in Yarn-master somehow when you download the ZIP from Git. I opened up data.js and added the fix manually, but it doesn't seem to work.
Dumb question, but do I need to compile something to get it to work?

[desplesda]

Comment by blurymind
Friday Apr 12, 2019 at 15:28 GMT

---

Please attach the example file :)

On Fri, Apr 12, 2019, 2:29 AM swakdaddy [email protected] wrote:

So I noticed that this fix doesn't seem to be included in Yarn-master
somehow when you download the ZIP from Git. I opened up data.js and added
the fix manually, but it doesn't seem to work.
Dumb question, but do I need to compile something to get it to work?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
InfiniteAmmoInc/Yarn#78 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGMbVTlQ_SndNiVaaXSIxbN1RV65IIRVks5vf-GIgaJpZM4WLhMz
.

[desplesda]

Comment by swakdaddy
Sunday Apr 14, 2019 at 12:54 GMT

---

The example file is already attached in the original post. See Sally.yarn.txt above.
It has the Windows-style line endings.
But, the problem is that this fix isn't in the git repo it seems. At least, not when I download it like this:

If you are talking about data.js, I simply changed the line in this change list to match what is supposed to be in git. It does not work locally by changing that file and then running Yarn by dragging Yarn-master folder into nw.exe. It's the only way I've found to run latest version of Yarn.

[desplesda]

Comment by blurymind
Monday Apr 15, 2019 at 07:46 GMT

---

@swakdaddy this was fixed on the electron branch. You need to use that instead of master
https://github.com/blurymind/Yarn/releases/tag/0.3.6

[desplesda]

Comment by swakdaddy
Thursday Apr 18, 2019 at 15:51 GMT

---

@blurymind - Ah thanks. I'll grab the electron branch then since it seems you guys have been working more on it!

[desplesda]

Comment by blurymind
Thursday Apr 18, 2019 at 16:24 GMT

---

It has alot of the issues here fixed, it's just not the default branch yet
for some reason

On Thu, Apr 18, 2019, 4:51 PM swakdaddy [email protected] wrote:

@blurymind https://github.com/blurymind - Ah thanks. I'll grab the
electron branch then since it seems you guys have been working more on it!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
InfiniteAmmoInc/Yarn#78 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRRWVKOOO5GNZ26772A7Q3PRCKG7ANCNFSM4FROCMZQ
.