Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows permission to allow forked PRs to have commented results #4105

Open
jasonwilliams opened this issue Dec 30, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jasonwilliams
Copy link
Member

Set the right permissions on workflows so benchmarks and test262 can be commented back to the PR

For a while we haven't been able to have test262 and benchmarks be commented back to forked PRs, it looks like there is a solution to this now.
boa-dev/criterion-compare-action#62 (comment)

So if the above is true, we just need to add the permissions line to here and here

@jasonwilliams jasonwilliams added the bug Something isn't working label Dec 30, 2024
@jasonwilliams jasonwilliams added the good first issue Good for newcomers label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant