Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add ability for custom meta tag logic #3

Open
Pinpickle opened this issue Jul 8, 2015 · 2 comments
Open

[RFC] Add ability for custom meta tag logic #3

Pinpickle opened this issue Jul 8, 2015 · 2 comments

Comments

@Pinpickle
Copy link
Contributor

I currently generate my meta tags manually with some twig logic, and for the most part it is similar to the logic in this extension, but every project does things slightly differently.

I don't know how this would be implemented, but it would be great if we could somehow provide our own ways of specifying meta tag values in the "fallback chain" of logic in this extension. For example, I may want the title to be the combination of two different fields, if they're filled, and then fall back to what the extension specifies.

@jasperjorna
Copy link
Contributor

Correct me if I'm wrong. Could this be achieved by simple overriding the template in the themes directory?

Currently it seems the path is prefixed though?

https://github.com/bobdenotter/seo/blob/master/Extension.php#L38

@bobdenotter
Copy link
Owner

I'm also not sure how to configure this.. Maybe allow for a 'general' seo title option, and the possibility to override them on a per-contenttype basis?

or, perhaps allow to override the title in the contenttypes.yml setting?

    fields:
        [..]
        seo:
            type: seo
            group: "SEO settings"
            title: [ name, subtitle ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants