diff --git a/cran-comments.md b/cran-comments.md index 59fc329..0b98dbe 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,30 +1,21 @@ ## Test environments -* Platform: x86_64-w64-mingw32/x64 (64-bit) - Running under: Windows >= 8 x64 (build 9200) - R version 3.5.0 +* Ubuntu 18.04 LTS + R version 3.5.2 * Ubuntu 14.04.5 LTS (on travis-ci with codename: trusty) - R version 3.5.1 + R version 3.5.2 * win-builder (devel and release) -* Local Ubuntu 17.04 (64-bit) with R devel and with clang 6.0.0 with ASAN and +* Local Ubuntu 18.04 with R 3.5.2 and with clang 6.0.0 with ASAN and UBSAN checks * The following rhub platforms: - debian-gcc-devel fedora-clang-devel fedora-gcc-devel debian-gcc-patched + debian-gcc-devel debian-gcc-release linux-x86_64-rocker-gcc-san I use the build with codename trusty for the GCC 4.8.4 which has C++11 support. -I am sorry for submitting so shortly after my previous release. I found two -major bugs in a new feature I have added. I hope you will accept this -submission and I understand if you do not. - -I have seen the Solaris issue and I think I have fixed it. I do not have access -to a Solaris machine and the `solaris-x86-patched` platform on rhub fails with -"Build timed out". - ## R CMD check results All platforms have a note about the package size except the win-builder with the devel version. diff --git a/tests/testthat/previous_results/print-ddsurvcurve b/tests/testthat/previous_results/print-ddsurvcurve new file mode 100644 index 0000000..8f90719 --- /dev/null +++ b/tests/testthat/previous_results/print-ddsurvcurve @@ -0,0 +1,3 @@ +Predicted survival curve from call: +ddsurvcurve(object = h1, new_data = data.frame(group = factor(2, + levels = 1:2))) diff --git a/tests/testthat/test_print.R b/tests/testthat/test_print.R index 4fa0ff1..32b07f6 100644 --- a/tests/testthat/test_print.R +++ b/tests/testthat/test_print.R @@ -135,5 +135,5 @@ test_that("print print.ddsurvcurve gives correct result", { ddcurve <- ddsurvcurve(h1, new_data = data.frame( group = factor(2, levels = 1:2))) - expect_known_output(ddcurve, file = "print-ddsurvcurve.txt", print = TRUE) + expect_known_output(ddcurve, file = "print-ddsurvcurve", print = TRUE) })