Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to move the end-to-end test to be an actual external-API test #428

Open
3 tasks
marsella opened this issue Jun 16, 2023 · 0 comments
Open
3 tasks

Try to move the end-to-end test to be an actual external-API test #428

marsella opened this issue Jun 16, 2023 · 0 comments

Comments

@marsella
Copy link

It doesn't really make sense that our end to end test full_protocol_execution_works poses as a unit test. It uses the public API of the library and should be an obvious and external test, since that's what it is. The only possible reason is that we're accessing some internal types to do validation; I'm not sure if this is the case.

  • Make an external test module per Rust's standard guidelines
  • Try to move the full protocol test to the external module
  • If there are any blockers / good reasons to keep it internal as a unit test, document them very clearly at the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant