Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check modulus size assumption in pi fac #502

Open
2 tasks
marsella opened this issue Oct 11, 2023 · 0 comments
Open
2 tasks

Check modulus size assumption in pi fac #502

marsella opened this issue Oct 11, 2023 · 0 comments
Labels
bug Something isn't working crypto

Comments

@marsella
Copy link

Some of the weirdness we uncovered while addressing #113 and #465 is due to an assumption in the last line of Fig 28:

The proof guarantees that each p, q > 2^ell (assuming 2^(2ell + ε ≈ √N0).

We don't check that assumption in the proof itself. In #466 we aim to check that assumption in at least one place, but it seems like it's worth checking in the proof verification itself as well, so we don't rely on it having been handled elsewhere.

  • Add modulus size check in proof verification
  • Review tests (especially those mentioned in Fix "negative tests" in pifac #465) and consider adding "small modulus" and "large modulus" tests that fail if the assumption doesn't hold.
@marsella marsella added the bug Something isn't working label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crypto
Projects
None yet
Development

No branches or pull requests

2 participants