Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out the Logger configuration. #45

Open
bonesoul opened this issue Jan 15, 2013 · 3 comments
Open

Refactor out the Logger configuration. #45

bonesoul opened this issue Jan 15, 2013 · 3 comments

Comments

@bonesoul
Copy link
Owner

As this isn't any kind of server-like software, I don't think we need configurable loggers. So I'll be refactoring out logger configuration functionality -- and will bind the console and file log will be just statically.

@bonesoul
Copy link
Owner Author

initial work: d36333d

@Delwin9999
Copy link

I'm always loathe to remove functionality and configurable loggers are wonderful for runtime debugging.

That said the overhead may not be worth it.

@bonesoul
Copy link
Owner Author

With the latest commit, I left them as still configurable ones.

Loggers are already initialized by the sample game where modifying the game.cs code and configuring them in-code is just similar to configuring them from the ini file.

And for release builds, I don't think anyone will be willing to let their users to configure game-clients logging functionality from the ini.

edwardmidkiff5 pushed a commit to edwardmidkiff5/voxeliq that referenced this issue Jun 4, 2024
Renamed Config.cs as SettingsReader.cs.
Initial work done for bonesoul/voxeliq#45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants