Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow images to workflow containers #96

Open
banchan86 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #97
Open

Update workflow images to workflow containers #96

banchan86 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #97

Comments

@banchan86
Copy link

Motivation

Pretty straightforward - some of the bonsai articles still have workflow images instead of workflow containers. In addition to them looking better in dark mode, the new workflow container allows the workflow to be copied for easier replication of examples.

Proposed solution

I have deleted the original workflow screenshots and replaced them with workflow containers linking to .bonsai files. In doing so I tried to keep the look of the original screenshots, and updated operator properties according to the tutorial or guide where-ever possible (some exceptions - changing the name of the operator for instance).

Additional context

There were 2 issues I came across -

  1. The Bonsai main docs is currently organised and setup differently from the other package repos, which is incompatible with the docfx-tools script to export workflow images. It's also missing github actions to build images so SVGs have to be included in the repo files. Wasn't sure if I would break anything else if I modified/reorganised the repo, for now I have just generated bonsai workflow images with another repo and added them in.

  2. There is one screenshot regarding scope of subjects that I cannot figure out. However I try to make a group workflow, it comes with a local scope, even if i'm not declaring any subjects. I might be just missing something really easy, but for now I have just updated the original screenshot with a style tag that switches colors in dark mode.

@banchan86 banchan86 linked a pull request Sep 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant