Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pilfer to Core #117

Open
vinniefalco opened this issue May 15, 2022 · 5 comments
Open

Add pilfer to Core #117

vinniefalco opened this issue May 15, 2022 · 5 comments

Comments

@vinniefalco
Copy link
Member

vinniefalco commented May 15, 2022

Add pilfer to Core so that it can be used by more than just Boost.JSON

@Lastique
Copy link
Member

I don't understand what's this about. Closing as spam.

@vinniefalco Please be clear about the problem description in future issues and avoid jargonisms.

@pdimov
Copy link
Member

pdimov commented May 16, 2022

It's a request to add pilfer to Core. pilfer currently exists in Boost.JSON detail, and has been proposed by me in P0308.

That'd actually be a legitimate addition to Core, for a change - the component is already present in another library and is needed as common infrastructure in others.

@pdimov pdimov reopened this May 16, 2022
@glenfe glenfe changed the title pilfer me timbers! Add pilfer to Core May 16, 2022
@breese
Copy link
Contributor

breese commented May 16, 2022

You may want to reconsider the name. This facility is a optimization on move semantics, and is thus special-purpose and less widely used. In such cases we should consider a longer, more expressive name, such as semi_destructive_move(), to make it more likely that arbitrary users understand the code without having to read up on "pilfering".

@vinniefalco
Copy link
Member Author

I like pilfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants