Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost.Graph no longer builds with C++03 #353

Open
mclow opened this issue Nov 10, 2023 · 6 comments
Open

Boost.Graph no longer builds with C++03 #353

mclow opened this issue Nov 10, 2023 · 6 comments
Assignees

Comments

@mclow
Copy link
Contributor

mclow commented Nov 10, 2023

It includes lexical_cast.h which no longer supports C++03.

@mclow
Copy link
Contributor Author

mclow commented Nov 10, 2023

Discovered in Boost 1.84.0 Beta 1 Release Candidate 1

@jeremy-murphy jeremy-murphy self-assigned this Nov 12, 2023
@jeremy-murphy
Copy link
Contributor

Is that actually an issue though? I thought all libraries were free to dispense with supporting pre-C++11 now? I've already taken the C+98 and C++03 CI builders out of the configurations for Drone and GitHub actions.

@mclow
Copy link
Contributor Author

mclow commented Nov 12, 2023

If you decide that Boost.Graph is no longer supporting c++03, that's your call.

But when I look at the docs and the meta/library.json file, I don't see any suggestion of that.

Many libraries have (or are in the process of) dispensing with C++03 support.
I see messages like this in my build logs:

./boost/smart_ptr/detail/requires_cxx11.hpp:19:1: warning: C++03 support was deprecated in Boost.SmartPtr 1.82 and will be removed in Boost.SmartPtr 1.84. Please open an issue in https://github.com/boostorg/smart_ptr if you want it retained. [-W#pragma-messages]

@jeremy-murphy
Copy link
Contributor

OK, good point, I should communicate it more explicitly.

@andrea-cassioli-maersk
Copy link
Contributor

What has been the decision here? I see still 03 in the meta/library.json file.

@jeremy-murphy
Copy link
Contributor

The decision is to drop C++03, the fact is I haven't had time to figure out how to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants