Adds a type-erased response adapter to the public API #201
Conversation
|
@anarthal Thanks, see my comments. |
|
Did you publish your comments? I can't see any of them |
|
Are you still going to work on this PR? |
|
whoa, I completely forgot about this! Yes, I'll finish it this incoming week. |
|
@mzimbres this is now complete on my side. Please let me know if any changes are required. |
|
Many thanks! Give me some days to review it. I would also say you this is worth listing in the Changelog. |
| } | ||
|
|
||
| template <class Executor> | ||
| friend class detail::connection_base; |
There was a problem hiding this comment.
I think there should be no friend class here, the class should define
void operator(std::size_t, resp3::basic_node<std::string_view> const&, system::error_code&)and forward the call directly to impl_. Once you do that you can also remove this typedef and replace it with any_adapter AFAICS.
In a later issue we will have to think about how this relates to the receiver adapter or whether we need another any adapter class. This will be needed to type erase the receive operation too
There was a problem hiding this comment.
This makes sense only if any_adapter is a public class - otherwise I can remove it (together with the Doxygen docs). See my question above.
There was a problem hiding this comment.
Ok, let us keep it public.
Would something along these lines suit you @mzimbres? If it does, I'll clean it up and write docs & tests for it.
close #128