Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the generic_response adapter #129

Open
mzimbres opened this issue Jul 30, 2023 · 0 comments
Open

Fix the generic_response adapter #129

mzimbres opened this issue Jul 30, 2023 · 0 comments

Comments

@mzimbres
Copy link
Collaborator

The generic_response adapter should not set an error in the result but let the caller check in each node whether an error occurred. Otherwise we cannot process responses to more than one request properly, like in the case of transactions.

The current implementation also has bug now since it might call result_->value() after an error has beed set in

*result_ = error{nd.data_type, std::string{std::cbegin(nd.value), std::cend(nd.value)}};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant