Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement django manifeststaticfilesstorage #1321

Open
rbbeeston opened this issue Oct 4, 2024 · 4 comments
Open

Implement django manifeststaticfilesstorage #1321

rbbeeston opened this issue Oct 4, 2024 · 4 comments

Comments

@rbbeeston
Copy link
Collaborator

Suggested by @brianjp93 to add the following to possibly fix the css caching problems when moving to staging or prod
https://docs.djangoproject.com/en/5.1/ref/contrib/staticfiles/#manifeststaticfilesstorage

Setting as high priority as it could save more time in the long run

@sdarwin
Copy link
Collaborator

sdarwin commented Oct 4, 2024

Submitted a PR to purge the cache, which should solve the problem in this issue.
At the same time, there is an open issue with Fastly, manifeststaticfilesstorage could possibly still be interesting. For now, wait and see.

@rbbeeston
Copy link
Collaborator Author

I assume the purge is a one time thing. it would be good to resolve this so it's not an issue every merge. You'd like me to hold on this until we hear back from fastly? Any idea what the timeline is on that? Thanks!

@sdarwin
Copy link
Collaborator

sdarwin commented Oct 4, 2024

I think we should go step-by-step and investigate the problem, while it's happening.

  • On staging, static/css/styles.css is supposed to have a TTL of 5 minutes. Has it ever exhibited the issue?
  • The new GHA purge will now run on each deploy. That's "one time" per merge, per pull request. What if this purge doesn't always solve it. We should collect evidence. Report the bug here, about which css file is out-of-date.

Fastly usually replies within 1-2 days.

In the meantime, if there is a deploy to production, you can log into Fastly and "Purge All" on boost.io.

@rbbeeston
Copy link
Collaborator Author

sounds good, as there are 3 possible css files that could be the issue, we should be able to tell which file is being missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Accepted
Development

No branches or pull requests

3 participants