Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries pages to use path based version to match the releases page #1360

Open
daveoconnor opened this issue Oct 15, 2024 · 4 comments
Assignees

Comments

@daveoconnor
Copy link
Collaborator

This ticket is from a discussion with @vinniefalco who was asking why the URL structures are different, why there's a query param in there instead of it being part of the URL. This is something that bugged me too when working on it, we can simplify the views and the shared code by unifying it to all being path based.

e.g.
/libraries/release/grid
/libraries/release/mini
/libraries/1.80.1/mini
/libraries/release/algorithm

@daveoconnor daveoconnor self-assigned this Oct 15, 2024
@daveoconnor
Copy link
Collaborator Author

Considerations would be:

  1. Any changes needed to have redirects for urls that are intended to match the old ones.
  2. Caching changes
  3. Possible removal of the cookie or a switch to session variable, multi-user use

@sdarwin
Copy link
Collaborator

sdarwin commented Oct 15, 2024

session variable

@daveoconnor the current cookie strategy include library_view and boost_version. This is working. It was after having sessions variables, and then removing session variables. which are not cdn-cachable. At least from the description of this issue 1360, the cookies can still be used.

@daveoconnor
Copy link
Collaborator Author

Thanks @sdarwin ,yeah, that's all working fine, and I don't think it necessarily needs to change, it was just something that came up in the discussion at the time because having to account for the cookie (or session variable has the same issue) is a cause of some of the edge case urls Vinnie wasn't liking and should be noted. Shouldn't be an issue if we switch to the new urls above.

@daveoconnor
Copy link
Collaborator Author

daveoconnor commented Oct 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants