You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to mention, this isn't a issue but a possible feature-request. And I'm sorry if I misunderstood or missed something, I don't think this is documented at the moment.
Current behavior
.is(anything, includingAlias) checks only for isBrowser, isOS and isPlatform but not for isEngine.
constbrowser=Bowser.getParser(window.navigator.userAgent)// Is Platformbrowser.is('desktop')// true// Is OSbrowser.is('macos')// true// Is Browserbrowser.is('chrome')// true// ---// Is Enginebrowser.is('blink')// false -> doesn't work// butbrowser.isEngine('blink')// true -> works as expected
Feature request
It would be great if we could use .is('isEngine') to check if the engine is called anything, just like we use it for platform, os or browser.
This makes it easier to use and removes possible doubts as to whether it's an bug or not.
// Currently this doesn't workbrowser.is('blink')
Additional info
I did a quick test and add || this.isEngine(anything) to this line. It turned out to work as expected.
Hi and thanks for your awesome work 👋
I want to mention, this isn't a issue but a possible
feature-request
. And I'm sorry if I misunderstood or missed something, I don't think this is documented at the moment.Current behavior
.is(anything, includingAlias)
checks only forisBrowser
,isOS
andisPlatform
but not forisEngine
.Feature request
It would be great if we could use
.is('isEngine')
to check if theengine
is calledanything
, just like we use it forplatform
,os
orbrowser
.This makes it easier to use and removes possible doubts as to whether it's an bug or not.
Additional info
I did a quick test and add
|| this.isEngine(anything)
to this line. It turned out to work as expected.is(anything, includingAlias = false) { return this.isBrowser(anything, includingAlias) || this.isOS(anything) + || this.isPlatform(anything) || this.isEngine(anything); }
Now we can check for
Engine
like this:The text was updated successfully, but these errors were encountered: